Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet): update balance finder style #4948

Merged
merged 70 commits into from
Feb 4, 2025
Merged

feat(wallet): update balance finder style #4948

merged 70 commits into from
Feb 4, 2025

Conversation

evavirseda
Copy link
Contributor

@evavirseda evavirseda commented Jan 21, 2025 •
edited
Loading

Description of change

Please write a summary of your changes and why you made them.

Links to any relevant issues

fixes #4808

Type of change

Choose a type of change, and delete any options that are not relevant.

  • Bug fix (a non-breaking change which fixes an issue)
  • Enhancement (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Fix

How the change has been tested

Describe the tests that you ran to verify your changes.

Make sure to provide instructions for the maintainer as well as any relevant configurations.

Change checklist

Tick the boxes that are relevant to your changes, and delete any items that are not.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that new and existing unit tests pass locally with my changes

@vercel Vercel
Copy link

vercel bot commented Jan 21, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
apps-ui-kit ⬜️ Ignored (Inspect) Visit Preview Feb 4, 2025 3:25pm
apps-backend ⬜️ Skipped (Inspect) Feb 4, 2025 3:25pm
rebased-explorer ⬜️ Skipped (Inspect) Feb 4, 2025 3:25pm
wallet-dashboard ⬜️ Skipped (Inspect) 💬 Add feedback Feb 4, 2025 3:25pm

@github-actions github-actions bot added apps-ui-kit Issues related to the Apps UI Kit wallet Issues related to the IOTA Wallet explorer Issues related to the Explorer labels Jan 21, 2025
@iota-ci iota-ci added the tooling Issues related to the Tooling team label Jan 21, 2025
panteleymonchuk and others added 17 commits January 22, 2025 17:08
@panteleymonchuk
feat(core): add StardustIndexerClient
9bd0183
@panteleymonchuk
feat(dashboard): add stardust objects from indexer.
8ca684e
@cpl121
feat: update balance finder fetch to include all relevant assets WIP
d071500
@panteleymonchuk
feat(core): enhance StardustIndexerClient with basic output mapping a…
e4e7c69 
…nd new types
@cpl121
Merge branch 'develop' into tooling-wallet/update-balance-finder-fetc…
ac691a6 
…h-relevant-assets
@cpl121
Merge branch 'develop' into tooling-wallet/add-objects-from-indexer
e8439d7
@cpl121
Merge branch 'tooling-wallet/add-objects-from-indexer' into tooling-w…
f4713c5 
…allet/update-balance-finder-fetch-relevant-assets
@panteleymonchuk
feat(dashboard): add NFT resolved outputs retrieval and mapping funct…
8884242 
…ions
@panteleymonchuk
Merge remote-tracking branch 'origin/develop' into tooling-wallet/add…
adedf67 
…-objects-from-indexer
@panteleymonchuk
refactor(core, dashboard): unify output types and enhance mapping fun…
01975e8 
…ctions
@cpl121
Merge branch 'tooling-wallet/add-objects-from-indexer' into tooling-w…
151fd0b 
…allet/update-balance-finder-fetch-relevant-assets
@panteleymonchuk
feat(wallet-dashboard, core): enhance Stardust output handling and ad…
6c9c84a 
…d pagination support
@panteleymonchuk
Merge remote-tracking branch 'origin/develop' into tooling-wallet/add…
88f9c02 
…-objects-from-indexer
@cpl121
Merge branch 'tooling-wallet/add-objects-from-indexer' into tooling-w…
a945c1c 
…allet/update-balance-finder-fetch-relevant-assets
@panteleymonchuk
Merge branch 'develop' into tooling-wallet/add-objects-from-indexer
47bebe0
@cpl121
fix(wallet): include stardustIndexerClient to fetch shared objects in…
3bb1c6f 
… balance finder
@panteleymonchuk
fix(core, dashboard): pr fixes
f176c64
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 3, 2025 16:22 Inactive
@cpl121 cpl121 self-requested a review February 3, 2025 16:22
begonaalvarezd
begonaalvarezd requested changes Feb 3, 2025
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just ran the balance finder from the accounts view and got an error
image
Used mnemonic rain flip mad lamp owner siren tower buddy wolf shy tray exit glad come dry tent they pond wrist web cliff mixed seek drum in alphanet

There are multiple errors in the console

marc2332
marc2332 requested changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't use hooks dynamically

@vercel vercel bot temporarily deployed to Preview – rebased-explorer February 4, 2025 11:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 4, 2025 11:28 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend February 4, 2025 11:28 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 4, 2025 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer February 4, 2025 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend February 4, 2025 14:43 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer February 4, 2025 14:55 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 4, 2025 14:55 Inactive
@vercel vercel bot temporarily deployed to Preview – apps-backend February 4, 2025 14:55 Inactive
@marc2332 marc2332 force-pushed the tooling-wallet/update-balance-finder-view branch from 2971173 to 662b862 Compare February 4, 2025 15:18
@vercel vercel bot temporarily deployed to Preview – apps-backend February 4, 2025 15:24 Inactive
@vercel vercel bot temporarily deployed to Preview – wallet-dashboard February 4, 2025 15:25 Inactive
@vercel vercel bot temporarily deployed to Preview – rebased-explorer February 4, 2025 15:25 Inactive
marc2332
marc2332 approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@marc2332 marc2332 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@begonaalvarezd begonaalvarezd merged commit b44f418 into develop Feb 4, 2025
34 checks passed
@begonaalvarezd begonaalvarezd deleted the tooling-wallet/update-balance-finder-view branch February 4, 2025 16:09
panteleymonchuk
panteleymonchuk approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@panteleymonchuk panteleymonchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems Begoña merged it before me, but anyway LGTM 😁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@marc2332 marc2332 marc2332 approved these changes

@panteleymonchuk panteleymonchuk panteleymonchuk approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees

@evavirseda evavirseda

Labels
apps-ui-kit Issues related to the Apps UI Kit explorer Issues related to the Explorer tooling Issues related to the Tooling team wallet Issues related to the IOTA Wallet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update balance finder style
6 participants
@evavirseda @begonaalvarezd @panteleymonchuk @marc2332 @cpl121 @iota-ci